Fix memory leak in Python extension module initialization #91
+55
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maratyszcza
requested changes
Aug 12, 2025
| Py_DECREF(model_type); | ||
| Py_DECREF(tokenizer_type); | ||
| Py_DECREF(context_type); | ||
|
|
There was a problem hiding this comment.
Duplicating deallocation code is undesirable. Instead, rename error: label to cleanup: and make it execute on both success and failure, similarly to
gpt-oss/gpt_oss/metal/source/model.c
Lines 432 to 440 in 906a0ef
|
@Maratyszcza done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a memory leak in the Metal Python extension module initialization by properly handling reference counting for type objects.
Problem
The original code used
PyModule_AddObject()which steals references, but the code was still decrementing reference counts in the error path, leading to potential memory leaks and incorrect reference counting.Solution
PyModule_AddObject()withPyModule_AddObjectRef()which handles reference counting correctlyPy_DECREF()calls after successful module addition sincePyModule_AddObjectRef()increments referencesPy_XDECREF()callsChanges
PyInit__metal()function ingpt_oss/metal/python/module.c